|
ETAInspectorView setEditable |
| Software Inspection Report Document | ||
|
Preparation sheet for software inspection of ETAInspectorView.setEditableReviewed by: Michael Hebron 1) Mental White Box Testing – for loop indexes array element that is out of bounds (goes from 0 to array length instead of 0 to array length – 1) 2) Coding Standard – unnecessary spaces around variables inside parentheses (ie "( editable )" instead of "(editable)"); local variable declarations aren't commented; no space in cast statement between type casting to and object being casted 3) Maintainability – unnecessary variable 'limit' declared; old pseudocode at top of method can be removed; unnecessary "end for" and "end while" comments Author: Apel Reviewer: Mike H Writer: Mike Power Work Product: ETAInspectorView.setEditable for loop increments one too far extra spaces around varibles local varible declarations lack comments loops of if branches lack comments need space when type casting between cast an Object Summary: Fail Issues: 5 Issues accepted: 5 |
||
| Issue# | Description | Acceptance |
| 1 | for loop increments one too far | Accept |
| 2 | extra spaces around varibles | Accept |
| 3 | local varible declarations lack comments | Accept |
| 4 | loops of if branches lack comments | Accept |
| 5 | need space when type casting between cast an Object | Accept |
| Software Inspection Summary | |||||
| Technical Defects Reported | 1 | Documentation Defects Reported | 0 | Coding Standard Defects Reported | 4 |
| Total Number of Defects | 5 | Overall Summary Pass or Fail | Fail | ||