|
ETAMainView CleanAllAction actionPerformed |
| Software Inspection Report Document | ||
| Preparation Sheet
Reviewer: Apel Author: Mike Power Work Product: ETAMainView.CleanAllAction.actionPerformed Mental White Box Testing: This method does not handle null at all. Perhaps in the preconditions there should be a list of varibles that should not return null. This method also has two while loops. One right after the other. Walking through the loops I can see that both are handled fine on their true and false branches. The iterator can handle ConcurrentModificationException. The code constructs a new ArrayList and retrieves the iterator from that collection so that it will not find its collection getting modified while it is reading from it. The code assumes the itr.next() call will return a ParameterDataInterface or ReturnedDataInterface depending on where the iterator comes from. This also is not in the pre conditions. This method will fail if the itr.next() call returns something other than a ParameterDataInterface or ReturnedDataInterface. Coding Standard Checking: At first glance everything seemed correct, but at a closer look I noticed that there was no space between the while and the (condnition) as required by coding standard. This should be corrected before the code is commited. Maintainability Checking: I am actually rather pleased with the comments. They still need work though. One thing I consider of most important note is the pre and post conditions. The pre condition should describes what parameters can't be null. Also the pre condition should in some way require the return of itr.next to be as expected. Also added to the post condition should be something to the effect of all ReturnedDataInterfaces and ParameterDat aInterfaces have their remove called. This will describe to the caller the exact result of the method. Other than that everything needed is present as far as I observe. |
| Software Inspection Summary | |||||
| Technical Defects Reported | 0 | Documentation Defects Reported | 0 | Coding Standard Defects Reported | 0 |
| Total Number of Defects | 0 | Overall Summary Pass or Fail | Pass | ||